我在这里使用遗留代码,并且有很多实例SqlDataReader
从未关闭或处置过。连接已关闭,但是我不确定是否需要手动管理阅读器。
这会导致性能下降吗?
Answers:
尽量避免使用这样的读者:
SqlConnection connection = new SqlConnection("connection string");
SqlCommand cmd = new SqlCommand("SELECT * FROM SomeTable", connection);
SqlDataReader reader = cmd.ExecuteReader();
connection.Open();
if (reader != null)
{
while (reader.Read())
{
//do something
}
}
reader.Close(); // <- too easy to forget
reader.Dispose(); // <- too easy to forget
connection.Close(); // <- too easy to forget
而是将它们包装在using语句中:
using(SqlConnection connection = new SqlConnection("connection string"))
{
connection.Open();
using(SqlCommand cmd = new SqlCommand("SELECT * FROM SomeTable", connection))
{
using (SqlDataReader reader = cmd.ExecuteReader())
{
if (reader != null)
{
while (reader.Read())
{
//do something
}
}
} // reader closed and disposed up here
} // command disposed here
} //connection closed and disposed here
using语句将确保正确处置对象和释放资源。
如果您忘记了,则将清理工作留给垃圾收集器,这可能需要一段时间。
请注意,处置使用SqlCommand.ExecuteReader()实例化的SqlDataReader 不会关闭/处置基础连接。
有两种常见的模式。首先,在连接范围内打开和关闭阅读器:
using(SqlConnection connection = ...)
{
connection.Open();
...
using(SqlCommand command = ...)
{
using(SqlDataReader reader = command.ExecuteReader())
{
... do your stuff ...
} // reader is closed/disposed here
} // command is closed/disposed here
} // connection is closed/disposed here
有时,使用数据访问方法打开连接并返回读取器很方便。在这种情况下,使用CommandBehavior.CloseConnection打开返回的阅读器非常重要,这样关闭/处置阅读器将关闭基础连接。该模式如下所示:
public SqlDataReader ExecuteReader(string commandText)
{
SqlConnection connection = new SqlConnection(...);
try
{
connection.Open();
using(SqlCommand command = new SqlCommand(commandText, connection))
{
return command.ExecuteReader(CommandBehavior.CloseConnection);
}
}
catch
{
// Close connection before rethrowing
connection.Close();
throw;
}
}
调用代码只需将读取器配置为:
using(SqlDataReader reader = ExecuteReader(...))
{
... do your stuff ...
} // reader and connection are closed here.
using
s,则finally {}
在catch之后在块中调用dispose 。编写方式,成功的命令将永远不会关闭或处置。
为了安全起见,将每个SqlDataReader对象包装在using语句中。